osmo-bts[master]: measurement: Improve log output

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Thu Apr 27 07:45:07 UTC 2017


Patch Set 1: Code-Review-1

(2 comments)

https://gerrit.osmocom.org/#/c/2389/1/src/common/measurement.c
File src/common/measurement.c:

Line 104: 	       "MEAS PERIOD END status:%d for chan:%u, TS:%u, SUBCHAN:%u, FN:%u, FN_MOD:%u\n",
typically we start the log line with some kind of identity, so TS and subcan number should be in the beginning.  Maybe event formatted similar to gsm_lchan_name() in case somebody wants to use a common grpe/regex to filter


https://gerrit.osmocom.org/#/c/2389/1/src/common/rsl.c
File src/common/rsl.c:

Line 2243: 	     "Send Meas RES: NUM:%d, RXLEV_FULL:%d, RXLEV_SUB:%d, RXQUAL_FULL:%d, RXQUAL_SUB:%d, MS_PWR:%d, UL_TA:%d, L3_LEN:%d, TimingOff:%u\n",
no gsm_lchan_name()


-- 
To view, visit https://gerrit.osmocom.org/2389
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic871eed6dcbc7d10aca6cd11dbc803b3e6da449f
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list