[PATCH] osmo-bts[master]: measurement: fix clearing of L1 info valid flag

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

dexter gerrit-no-reply at lists.osmocom.org
Wed Apr 26 09:38:40 UTC 2017


Review at  https://gerrit.osmocom.org/2413

measurement: fix clearing of L1 info valid flag

The layer 1 info valid flag is cleared by rsl_tx_meas_res() when
a valid layer 1 info is transmitted via rsl.

The flag is now cleared by lchan_meas_update_ordered_TA() in
measurement.c, which means that clearing it in rsl.c is no longer
needed.

Change-Id: Ie511cba7927b4ab80a5b7551c39a253cee14eace
---
M src/common/rsl.c
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/13/2413/1

diff --git a/src/common/rsl.c b/src/common/rsl.c
index a542324..7db9939 100644
--- a/src/common/rsl.c
+++ b/src/common/rsl.c
@@ -2261,7 +2261,8 @@
 	msgb_tv_put(msg, RSL_IE_BS_POWER, lchan->meas.bts_tx_pwr);
 	if (lchan->meas.flags & LC_UL_M_F_L1_VALID) {
 		msgb_tv_fixed_put(msg, RSL_IE_L1_INFO, 2, lchan->meas.l1_info);
-		lchan->meas.flags &= ~LC_UL_M_F_L1_VALID;
+		/* Note: L1 info valid flag is cleared by function
+		 * lchan_meas_update_ordered_TA() in measurement.c */
 	}
 	msgb_tl16v_put(msg, RSL_IE_L3_INFO, l3_len, l3);
 		//msgb_tv_put(msg, RSL_IE_MS_TIMING_OFFSET, FIXME);

-- 
To view, visit https://gerrit.osmocom.org/2413
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie511cba7927b4ab80a5b7551c39a253cee14eace
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: dexter <pmaier at sysmocom.de>



More information about the gerrit-log mailing list