libosmo-netif[master]: osmux: Add RTP marker bit support

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Wed Apr 26 08:23:30 UTC 2017


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/2407/1/include/osmocom/netif/osmux.h
File include/osmocom/netif/osmux.h:

PS1, Line 35: r
> doesn't this break backwards compatibility?  The FT has one less bit - ok. 
Indeed, it brakes backwards compatibility. But leaving rtp_m on the 3rd bit I guess would break backwards compatibility anyways. At least if the sender sets the rtp_m bit to 1, then the receiver uses the older version it would not be able to find out which type of packet is it and it would drop it.

Of course, the situation would be a better because most packets are probably not dropped. I initially did it this way to have more logical ordering of the fields, but I actually realize other ones are not in the most logical order but just trying to optimize space, so I'll move rtp_m to be next to ft.


-- 
To view, visit https://gerrit.osmocom.org/2407
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0315658159429603f1d80a168718b026015060e9
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list