[PATCH] osmo-bts[master]: measurement/cosmetic: Fixup source code comment

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

dexter gerrit-no-reply at lists.osmocom.org
Thu Apr 20 13:14:36 UTC 2017


Review at  https://gerrit.osmocom.org/2387

measurement/cosmetic: Fixup source code comment

the function ber10k_to_rxqual() has only a very brief
comment with the spec reference. This commit adds a more
explainatory comment that makes it easier to understand
from where the ber10k constants are taken.

Change-Id: I3d3488c97d0bffa7d449d3675afcc75b2a6a2703
---
M src/common/measurement.c
1 file changed, 14 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/87/2387/1

diff --git a/src/common/measurement.c b/src/common/measurement.c
index 6a11888..0814bf1 100644
--- a/src/common/measurement.c
+++ b/src/common/measurement.c
@@ -114,7 +114,20 @@
 /* input: BER in steps of .01%, i.e. percent/100 */
 static uint8_t ber10k_to_rxqual(uint32_t ber10k)
 {
-	/* 05.08 / 8.2.4 */
+	/* Eight levels of Rx quality are defined and are mapped to the
+	 * equivalent BER before channel decoding, as per in 3GPP TS 45.008,
+	 * secton 8.2.4.
+	 *
+	 * RxQual:				BER Range:
+	 * RXQUAL_0	     BER <  0,2 %       Assumed value = 0,14 %
+	 * RXQUAL_1  0,2 % < BER <  0,4 %	Assumed value = 0,28 %
+	 * RXQUAL_2  0,4 % < BER <  0,8 %	Assumed value = 0,57 %
+	 * RXQUAL_3  0,8 % < BER <  1,6 %	Assumed value = 1,13 %
+	 * RXQUAL_4  1,6 % < BER <  3,2 %	Assumed value = 2,26 %
+	 * RXQUAL_5  3,2 % < BER <  6,4 %	Assumed value = 4,53 %
+	 * RXQUAL_6  6,4 % < BER < 12,8 %	Assumed value = 9,05 %
+	 * RXQUAL_7 12,8 % < BER		Assumed value = 18,10 % */
+
 	if (ber10k < 20)
 		return 0;
 	if (ber10k < 40)

-- 
To view, visit https://gerrit.osmocom.org/2387
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3d3488c97d0bffa7d449d3675afcc75b2a6a2703
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: dexter <pmaier at sysmocom.de>



More information about the gerrit-log mailing list