osmo-bts[master]: Prepare for extended SI2quater support

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Tue Apr 18 13:02:02 UTC 2017


Patch Set 2: Code-Review+2

(1 comment)

https://gerrit.osmocom.org/#/c/2313/2/src/common/rsl.c
File src/common/rsl.c:

Line 439: 		len = sizeof(sysinfo_buf_t) - 2;
does truncation here make sense? should we not at the very least print a LOGL_ERROR message that we are effectively generating broken messages? I know you just moved the code, but maybe as a follow-up commit?


-- 
To view, visit https://gerrit.osmocom.org/2313
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie97be6ead6ce6d2d425fbfac8429bb90afb95acc
Gerrit-PatchSet: 2
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list