[MERGED] libosmo-sccp[master]: xua_as_fsm: We might change to AS_INACTIVE after T(r) expiry

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Mon Apr 17 07:51:21 UTC 2017


Harald Welte has submitted this change and it was merged.

Change subject: xua_as_fsm: We might change to AS_INACTIVE after T(r) expiry
......................................................................


xua_as_fsm: We might change to AS_INACTIVE after T(r) expiry

Depending on whether or not any ASP is INACTIVE, we need to go to
AS_INACTIVE or AS_DOWN after T(r) expiry in the xua_as_fsm.

Found by m3ua-testtool testcase m3ua-sgp-aspsm-o-003

Change-Id: Iad6b176a5c95a28fbd5ba437696c2e6e160bdb00
---
M src/xua_as_fsm.c
1 file changed, 4 insertions(+), 1 deletion(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/xua_as_fsm.c b/src/xua_as_fsm.c
index 282a6bf..36aed64 100644
--- a/src/xua_as_fsm.c
+++ b/src/xua_as_fsm.c
@@ -296,7 +296,10 @@
 		LOGPFSM(fi, "T(r) expired; dropping queued messages\n");
 		while ((msg = msgb_dequeue(&xafp->recovery.queued_msgs)))
 			talloc_free(msg);
-		osmo_fsm_inst_state_chg(fi, XUA_AS_S_DOWN, 0, 0);
+		if (check_any_other_asp_not_down(xafp->as, NULL))
+			osmo_fsm_inst_state_chg(fi, XUA_AS_S_INACTIVE, 0, 0);
+		else
+			osmo_fsm_inst_state_chg(fi, XUA_AS_S_DOWN, 0, 0);
 		break;
 	case XUA_AS_E_TRANSFER_REQ:
 		/* enqueue the to-be-transferred message */

-- 
To view, visit https://gerrit.osmocom.org/2381
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iad6b176a5c95a28fbd5ba437696c2e6e160bdb00
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder



More information about the gerrit-log mailing list