[MERGED] libosmo-sccp[master]: osmo_ss7: Fix protocol of dynamically allocated ASPs

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Sun Apr 16 01:30:30 UTC 2017


Harald Welte has submitted this change and it was merged.

Change subject: osmo_ss7: Fix protocol of dynamically allocated ASPs
......................................................................


osmo_ss7: Fix protocol of dynamically allocated ASPs

When dynamically allocating ASPs, we used the hardcoded M3UA protocol,
which is of course wrong in case of SUA or other protocols.  Let's use
the xua_server's configured protocol for the created ASPs.

Change-Id: I07832cbaf1ca42f0c7df399e4f96599034b72816
---
M src/osmo_ss7.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/osmo_ss7.c b/src/osmo_ss7.c
index 44f34fe..95c5fb1 100644
--- a/src/osmo_ss7.c
+++ b/src/osmo_ss7.c
@@ -1464,7 +1464,7 @@
 			static uint32_t dyn_asp_num = 0;
 			snprintf(namebuf, sizeof(namebuf), "asp-dyn-%u", dyn_asp_num++);
 			asp = osmo_ss7_asp_find_or_create(oxs->inst, namebuf, 0, 0,
-							  OSMO_SS7_ASP_PROT_M3UA);
+							  oxs->cfg.proto);
 			if (asp) {
 				LOGP(DLSS7, LOGL_INFO, "%s: created dynamicASP %s\n",
 					sock_name, asp->cfg.name);

-- 
To view, visit https://gerrit.osmocom.org/2359
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I07832cbaf1ca42f0c7df399e4f96599034b72816
Gerrit-PatchSet: 2
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder



More information about the gerrit-log mailing list