[MERGED] libosmo-sccp[master]: osmo_ss7: Instruct libosmo-netif to use {TCP, SCTP}_NODELAY o...

[Harald Welte]

Harald Welte has submitted this change and it was merged.

Change subject: osmo_ss7: Instruct libosmo-netif to use {TCP,SCTP}_NODELAY on all sockets
......................................................................


osmo_ss7: Instruct libosmo-netif to use {TCP,SCTP}_NODELAY on all sockets

If we don't do this, we get some nasty packet delays, which are
sufficient enough to trigger re-transmissions of an M3UA ASP-UP packet
even over loopback/localhost on an otherwise unloaded system.

Change-Id: I6aa4eb421ecb483d3da1b0ce3aa6511d161c3750
---
M src/osmo_ss7.c
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/osmo_ss7.c b/src/osmo_ss7.c
index 2c17e15..7da9ba3 100644
--- a/src/osmo_ss7.c
+++ b/src/osmo_ss7.c
@@ -1044,6 +1044,7 @@
 				" client for ASP %s\n", asp->cfg.name);
 			return -1;
 		}
+		osmo_stream_cli_set_nodelay(asp->client, true);
 		osmo_stream_cli_set_addr(asp->client, asp->cfg.remote.host);
 		osmo_stream_cli_set_port(asp->client, asp->cfg.remote.port);
 		osmo_stream_cli_set_local_addr(asp->client, asp->cfg.local.host);
@@ -1505,6 +1506,7 @@
 	osmo_stream_srv_link_set_data(oxs->server, oxs);
 	osmo_stream_srv_link_set_accept_cb(oxs->server, xua_accept_cb);
 
+	osmo_stream_srv_link_set_nodelay(oxs->server, true);
 	osmo_stream_srv_link_set_addr(oxs->server, oxs->cfg.local.host);
 	osmo_stream_srv_link_set_port(oxs->server, oxs->cfg.local.port);
 	osmo_stream_srv_link_set_proto(oxs->server, IPPROTO_SCTP);

-- 
To view, visit https://gerrit.osmocom.org/2299
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6aa4eb421ecb483d3da1b0ce3aa6511d161c3750
Gerrit-PatchSet: 3
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder