[MERGED] libosmo-sccp[master]: M3UA: Respond with "Unexpected Message" if ASPTM is received...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Mon Apr 10 11:26:56 UTC 2017


Harald Welte has submitted this change and it was merged.

Change subject: M3UA: Respond with "Unexpected Message" if ASPTM is received too soon
......................................................................


M3UA: Respond with "Unexpected Message" if ASPTM is received too soon

This was discovered (and fix validated) using m3ua-sgp-aspsm-i-003
of Michale Tuexen's m3ua-testtool.

Change-Id: I8b63e7b5e39a7ef8dd66bf014110a04f5f3dc2a2
---
M src/m3ua.c
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/m3ua.c b/src/m3ua.c
index 92470d7..14df269 100644
--- a/src/m3ua.c
+++ b/src/m3ua.c
@@ -623,7 +623,8 @@
 		return M3UA_ERR_UNSUPP_MSG_TYPE;
 
 	/* deliver that event to the ASP FSM */
-	osmo_fsm_inst_dispatch(asp->fi, event, xua);
+	if (osmo_fsm_inst_dispatch(asp->fi, event, xua) < 0)
+		return M3UA_ERR_UNEXPECTED_MSG;
 
 	return 0;
 }

-- 
To view, visit https://gerrit.osmocom.org/2269
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8b63e7b5e39a7ef8dd66bf014110a04f5f3dc2a2
Gerrit-PatchSet: 7
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder



More information about the gerrit-log mailing list