libosmo-netif[master]: stream/datagram: Ensure reliable close/destroy

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Holger Freyther gerrit-no-reply at lists.osmocom.org
Mon Apr 10 08:58:23 UTC 2017


Patch Set 3:

(1 comment)

https://gerrit.osmocom.org/#/c/2253/3/src/datagram.c
File src/datagram.c:

PS3, Line 196: osmo_sock_init2
> Thanks for your review!  Howeveer, if it was >= 0 a few lines above, we wou
To be honest I have to see how it is used. So just by reviewing this file I see..

osmo_dgram_create()
conn->tx->flags = BOGUS; (or dns failure?)
osmo_dgram_open()
  osmo_dgram_tx_open()
     ret = -int
     if (ret < 0)
          return ret;

conn->fd == 0 after that.

So the OSMO_DGRAM_CLI_F_RECONF case would not be hit?

For sure it is a corner case and would require the bind/resolving to fail or passing wrong flags.


-- 
To view, visit https://gerrit.osmocom.org/2253
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29c37da6e8f5be8ab030e68952a8f92add146821
Gerrit-PatchSet: 3
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list