[PATCH] libosmo-sccp[master]: M3UA: Send "Unexpected Message" when receiving ASP_UP-ACK in...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Sun Apr 9 19:31:09 UTC 2017


Hello Jenkins Builder,

I'd like you to reexamine a change.  Please visit

    https://gerrit.osmocom.org/2271

to look at the new patch set (#5).

M3UA: Send "Unexpected Message" when receiving ASP_UP-ACK in ACTIVE

Change-Id: Ibcda68b7acb02bf1580a832baff06ff21cbac713
---
M src/xua_asp_fsm.c
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/71/2271/5

diff --git a/src/xua_asp_fsm.c b/src/xua_asp_fsm.c
index 87f8927..0996db0 100644
--- a/src/xua_asp_fsm.c
+++ b/src/xua_asp_fsm.c
@@ -527,10 +527,10 @@
 		 * an Error message ("Unexpected Message), and the
 		 * remote ASP state is changed to ASP-INACTIVE in all
 		 * relevant Application Servers */
-		/* FIXME: Send ERROR message */
 		osmo_fsm_inst_state_chg(fi, XUA_ASP_S_INACTIVE, 0, 0);
 		send_xlm_prim_simple(fi, OSMO_XLM_PRIM_M_ASP_INACTIVE,
 				     PRIM_OP_INDICATION);
+		peer_send_error(fi, M3UA_ERR_UNEXPECTED_MSG);
 		break;
 	}
 }

-- 
To view, visit https://gerrit.osmocom.org/2271
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibcda68b7acb02bf1580a832baff06ff21cbac713
Gerrit-PatchSet: 5
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder



More information about the gerrit-log mailing list