[PATCH] libosmo-sccp[master]: osmo_ss7: Fix msgb memory leaks in error paths (asp not conn...

[Harald Welte]

Hello Jenkins Builder,

I'd like you to reexamine a change.  Please visit

    https://gerrit.osmocom.org/2267

to look at the new patch set (#5).

osmo_ss7: Fix msgb memory leaks in error paths (asp not connected)

Change-Id: I031d90348ea243ac5dbdde14365528f3ec8e3709
---
M src/osmo_ss7.c
1 file changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/67/2267/5

diff --git a/src/osmo_ss7.c b/src/osmo_ss7.c
index d3b71e7..9c886c4 100644
--- a/src/osmo_ss7.c
+++ b/src/osmo_ss7.c
@@ -1419,6 +1419,7 @@
 		if (!asp->server) {
 			LOGPASP(asp, DLSS7, LOGL_ERROR, "Cannot transmit, no asp->server\n");
 			/* FIXME: what to do here? delete the route? send DUNA? */
+			msgb_free(msg);
 			return -EIO;
 		}
 		osmo_stream_srv_send(asp->server, msg);
@@ -1426,6 +1427,7 @@
 		if (!asp->client) {
 			LOGPASP(asp, DLSS7, LOGL_ERROR, "Cannot transmit, no asp->client\n");
 			/* FIXME: what to do here? delete the route? send DUNA? */
+			msgb_free(msg);
 			return -EIO;
 		}
 		osmo_stream_cli_send(asp->client, msg);

-- 
To view, visit https://gerrit.osmocom.org/2267
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I031d90348ea243ac5dbdde14365528f3ec8e3709
Gerrit-PatchSet: 5
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder