This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgHarald Welte has submitted this change and it was merged. Change subject: abis: log known ACKs and unknown messages ...................................................................... abis: log known ACKs and unknown messages Log expected ACK messages and unhandled messages to aid in troubleshooting. Change-Id: Id3afaaa76e24f63076ae0e6fd2322e4a7fa29b45 Related: OS#1614 --- M openbsc/src/libbsc/abis_nm.c 1 file changed, 18 insertions(+), 1 deletion(-) Approvals: Harald Welte: Looks good to me, approved Jenkins Builder: Verified diff --git a/openbsc/src/libbsc/abis_nm.c b/openbsc/src/libbsc/abis_nm.c index 33a23a2..651ca02 100644 --- a/openbsc/src/libbsc/abis_nm.c +++ b/openbsc/src/libbsc/abis_nm.c @@ -694,8 +694,21 @@ case NM_MT_BS11_LMT_SESSION: ret = abis_nm_rx_lmt_event(mb); break; + case NM_MT_OPSTART_ACK: + abis_nm_debugp_foh(DNM, foh); + DEBUGPC(DNM, "Opstart ACK\n"); + break; + case NM_MT_SET_CHAN_ATTR_ACK: + abis_nm_debugp_foh(DNM, foh); + DEBUGPC(DNM, "Set Channel Attributes ACK\n"); + break; + case NM_MT_SET_RADIO_ATTR_ACK: + abis_nm_debugp_foh(DNM, foh); + DEBUGPC(DNM, "Set Radio Carrier Attributes ACK\n"); + break; case NM_MT_CONN_MDROP_LINK_ACK: - DEBUGP(DNM, "CONN MDROP LINK ACK\n"); + abis_nm_debugp_foh(DNM, foh); + DEBUGPC(DNM, "CONN MDROP LINK ACK\n"); break; case NM_MT_IPACC_RESTART_ACK: osmo_signal_dispatch(SS_NM, S_NM_IPACC_RESTART_ACK, NULL); @@ -705,6 +718,10 @@ break; case NM_MT_SET_BTS_ATTR_ACK: break; + default: + abis_nm_debugp_foh(DNM, foh); + LOGPC(DNM, LOGL_ERROR, "Unhandled message %s\n", + get_value_string(abis_nm_msgtype_names, mt)); } abis_nm_queue_send_next(bts); -- To view, visit https://gerrit.osmocom.org/2227 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id3afaaa76e24f63076ae0e6fd2322e4a7fa29b45 Gerrit-PatchSet: 5 Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Owner: Max <msuraev at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder