[MERGED] osmo-iuh[master]: hnbgw: Fix crash if cnlink fails to connect

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Fri Apr 7 10:20:06 UTC 2017


Pau Espin Pedrol has submitted this change and it was merged.

Change subject: hnbgw: Fix crash if cnlink fails to connect
......................................................................


hnbgw: Fix crash if cnlink fails to connect

Return NULL in the error code path, otherwise an uninitialized pointer
is returned and later accessed when a UE tries to register using the
cnlink.

Change-Id: I4f3e2e0680de3216e2e569958bd64f70dc30c2a3
---
M src/hnbgw_cn.c
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/hnbgw_cn.c b/src/hnbgw_cn.c
index 0e993e2..4e5b2e0 100644
--- a/src/hnbgw_cn.c
+++ b/src/hnbgw_cn.c
@@ -409,4 +409,5 @@
 	osmo_sua_user_destroy(cnlink->sua_user);
 out_free:
 	talloc_free(cnlink);
+	return NULL;
 }

-- 
To view, visit https://gerrit.osmocom.org/2232
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4f3e2e0680de3216e2e569958bd64f70dc30c2a3
Gerrit-PatchSet: 1
Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>



More information about the gerrit-log mailing list