libosmocore[master]: gsm0808: Add utils for Speech Codec List and Speech Codec

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Tue Apr 4 12:51:12 UTC 2017


Patch Set 3: Code-Review+1

(3 comments)

with const, it would be perfect :)

https://gerrit.osmocom.org/#/c/2177/3/include/osmocom/gsm/gsm0808_utils.h
File include/osmocom/gsm/gsm0808_utils.h:

Line 28: 				    struct sockaddr_storage *ss);
const


Line 36: 				 struct gsm0808_speech_codec *sc);
for encoding functions, we generally use "const *" input to indicate that this is read-only input data.


Line 44: 				      struct gsm0808_speech_codec_list *scl);
const


-- 
To view, visit https://gerrit.osmocom.org/2177
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0e1e2edf47adaa45b22d4b0bcae3640dba7ca200
Gerrit-PatchSet: 3
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list