openbsc[master]: gsm_bts: add version and variant details

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Mon Apr 3 10:37:19 UTC 2017


Patch Set 3:

(2 comments)

https://gerrit.osmocom.org/#/c/2161/3/openbsc/include/openbsc/gsm_data_shared.h
File openbsc/include/openbsc/gsm_data_shared.h:

Line 502: 	BTS_UNKNOWN,
better call those BTS__OSMO_... to indicate they're sub-variants of OSMOBTS.


https://gerrit.osmocom.org/#/c/2161/3/openbsc/src/libbsc/bts_sysmobts.c
File openbsc/src/libbsc/bts_sysmobts.c:

Line 48: 	model_sysmobts.name = "sysmobts";
we need to do something about the string name.  Old configurations with 'sysmobts' should map that to 'osmobts' and new config files should be written with 'osmobts'.

Also, the code in this file should contain some explanation, i.e. that osmo-bts was primarily written for sysmobts and later extended to other models/vendors, hence this code refers to sysmobts but also works with other models.


-- 
To view, visit https://gerrit.osmocom.org/2161
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6710d53115f34634a7b70969cc05fd5c72ff8ab2
Gerrit-PatchSet: 3
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list