This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgPatch Set 6: Code-Review-1 (6 comments) Disclaimer: I think the higher level discussion with Holger still needs to be resolved, I am focusing on the implementation details instead. https://gerrit.osmocom.org/#/c/819/6//COMMIT_MSG Commit Message: Line 12: Since 2nd DL TBF has less DL slot compared to 2nd TBF, 'less DL slots' with 's' Line 13: There is a difference in throughput between lower case after comma Line 18: Also mention here that maximise_direction is chosen to be an enum to be open for later additions. https://gerrit.osmocom.org/#/c/819/6/src/gprs_rlcmac_ts_alloc.cpp File src/gprs_rlcmac_ts_alloc.cpp: Line 782: break; indent break; with one more tab, see all other osmo code. https://gerrit.osmocom.org/#/c/819/6/src/pcu_vty.c File src/pcu_vty.c: Line 500: #define MAXIMISE_STR "Maximise direction based on configuration\n" I *still* don't like the 'based on configuration'. Everything in the VTY is based on configuration. Describe the direction of *what* is being maximised. After all, you can't maximise a direction per se, you maximise flow in a certain direction -- flow of what? Line 502: DEFUN(cfg_pcu_ts_alloc_maximise, usually, the naming here corresponds to the node and the VTY command, so I'd name this 'cfg_pcu_maximise_direction*', same as you have done for the 'no maximise-direction' below. -- To view, visit https://gerrit.osmocom.org/819 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4b4a99194ccae68bb3417bce538d16e944d5ec71 Gerrit-PatchSet: 6 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: arvind.sirsikar <arvind.sirsikar at radisys.com> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Holger Freyther <holger at freyther.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: arvind.sirsikar <arvind.sirsikar at radisys.com> Gerrit-HasComments: Yes