This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgPatch Set 4: (3 comments) https://gerrit.osmocom.org/#/c/862/4//COMMIT_MSG Commit Message: Line 16: the remaining bits. much better, thanks :) https://gerrit.osmocom.org/#/c/862/2/src/rlc.cpp File src/rlc.cpp: Line 108: unsigned num_blocks = rbb->cur_bit > (unsigned)distance() > The distance is supposed to be positive. But earlier return type is signed. It is not enough that it is supposed to be positive, it must be *guaranteed* to be positive, or this cast will blow up in our faces. https://gerrit.osmocom.org/#/c/862/4/src/tbf_dl.cpp File src/tbf_dl.cpp: Line 939: I've tried for some minutes to understand, but I don't see it yet... why can this if() block be removed? The calculations removed here are somewhat different than the simpler num_blocks calculation added above, could you please help me to match them up? -- To view, visit https://gerrit.osmocom.org/862 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id07d178970f168f5389016c1eea31eb6b82057b6 Gerrit-PatchSet: 4 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: arvind.sirsikar <arvind.sirsikar at radisys.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: arvind.sirsikar <arvind.sirsikar at radisys.com> Gerrit-HasComments: Yes