This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgPatch Set 3: Code-Review-2 (1 comment) https://gerrit.osmocom.org/#/c/902/3/src/common/rsl.c File src/common/rsl.c: Line 1602: speech_mode = TLVP_VAL(&tp, RSL_IE_IPAC_SPEECH_MODE); the comment doesn't match the code. As the comment suggests, anyof those information elements can not be present in the message, as they are optional IEs. The existing code *should* deal with that. The new code unconditionally introduces logging code that de-references the pointers, which might be NULL -> boom. -- To view, visit https://gerrit.osmocom.org/902 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifaa253e5baed5ca364dfbc046a7cb559f106bfbd Gerrit-PatchSet: 3 Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-HasComments: Yes