openbsc[master]: OML: Fixing static OML attribute tables

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Fri Sep 30 12:41:19 UTC 2016


Patch Set 1: Code-Review-1

Rather than hand-encoding the message, I was originally more hoping for passing asomething like a tlvp_parsed structure into an encoder, which then builds the respective message by calling one generic function that puts together all the IEs.  

But well, the important part is to fix the current bug, so let's not over-complicate things and keep the approach you implemented.

However, what we must do is to verify such a change. In order to do so, we should
* generate the respective OML messages using the old code
* capture the binary (e.g. with wireshark, or by hexdumping it)
* write a test case using that binary data, testing the old implementation
* change the implementation, run the old test case[s] with the old binary data against the new implementation, to verify it still generates identical binary data as before.

-- 
To view, visit https://gerrit.osmocom.org/973
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibeb34a84912d6cf695f553a34c69320fca7d08fa
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: No



More information about the gerrit-log mailing list