[PATCH] libosmocore[master]: NOT FOR MERGE: introduce ASAN failure to test jenkins.sh

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Fri Sep 30 00:07:20 UTC 2016


Hello Jenkins Builder,

I'd like you to reexamine a change.  Please visit

    https://gerrit.osmocom.org/975

to look at the new patch set (#4).

NOT FOR MERGE: introduce ASAN failure to test jenkins.sh

Change-Id: I9b0b22d5163bd1243f6ea0e25bce15e0a626000d
---
M contrib/jenkins.sh
M tests/bits/bitrev_test.c
M tests/bits/bitrev_test.ok
3 files changed, 7 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/75/975/4

diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh
index e53c6d8..56b8a98 100755
--- a/contrib/jenkins.sh
+++ b/contrib/jenkins.sh
@@ -4,5 +4,7 @@
 
 autoreconf --install --force
 ./configure --enable-static --enable-sanitize
-$MAKE $PARALLEL_MAKE check
-$MAKE distcheck
+$MAKE V=1 $PARALLEL_MAKE check \
+  || cat-testlogs.sh
+$MAKE distcheck \
+  || cat-testlogs.sh
diff --git a/tests/bits/bitrev_test.c b/tests/bits/bitrev_test.c
index ed3939a..e84a898 100644
--- a/tests/bits/bitrev_test.c
+++ b/tests/bits/bitrev_test.c
@@ -300,9 +300,7 @@
 		sh_chk(in1, ARRAY_SIZE(in1), offs, true);
 		sh_chk(in1, ARRAY_SIZE(in1), offs, false);
 		sh_chk(in2, ARRAY_SIZE(in2), offs, true);
-		/* in2 is too short to shift left 12 nibbles */
-		if (offs < 12)
-			sh_chk(in2, ARRAY_SIZE(in2), offs, false);
+		sh_chk(in2, ARRAY_SIZE(in2), offs, false);
 	}
 	return 0;
 }
diff --git a/tests/bits/bitrev_test.ok b/tests/bits/bitrev_test.ok
index d2fb12c..f58f070 100644
--- a/tests/bits/bitrev_test.ok
+++ b/tests/bits/bitrev_test.ok
@@ -156,3 +156,5 @@
      OUT: 00dcafedeadb
 [6] R IN: b00bbabeface, nibble 12:
      OUT: 0b00bbabefac
+[6] L IN: b00bbabeface, nibble 12:
+     OUT: 00bbabeface0

-- 
To view, visit https://gerrit.osmocom.org/975
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9b0b22d5163bd1243f6ea0e25bce15e0a626000d
Gerrit-PatchSet: 4
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder



More information about the gerrit-log mailing list