osmo-pcu[master]: EGPRS: add test case to show EPDAN BSN out of window bug

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

arvind.sirsikar gerrit-no-reply at lists.osmocom.org
Thu Sep 29 13:43:04 UTC 2016


Patch Set 2:

(4 comments)

https://gerrit.osmocom.org/#/c/861/2/tests/tbf/TbfTest.cpp
File tests/tbf/TbfTest.cpp:

Line 2019: }
> a single blank line between function definitions
Done


Line 2022:  * version 7.27.0 Release 7. which explains the Interpretation of the bitmap
> ". Which" or ", which"
Done


Line 2036: 	uint8_t rbb[64/8];
> is this 64 by chance related to RLC_EGPRS_MIN_WS, or RLC_EGPRS_WS?
not related to this test case. removing.


Line 2049: 	 * used to simulate the EPDAN out of window scenario. During
> "used used".
Done


-- 
To view, visit https://gerrit.osmocom.org/861
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If32b67f5c05707155281128b776a90a1e3d587b2
Gerrit-PatchSet: 2
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Owner: arvind.sirsikar <arvind.sirsikar at radisys.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: arvind.sirsikar <arvind.sirsikar at radisys.com>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list