This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
dexter gerrit-no-reply at lists.osmocom.orgReview at https://gerrit.osmocom.org/963 SGSN: Fixing build config Tests for V.42bis, slhc, llc-xid and sndcp-xid are built and executed on all build configurations, but are only needed when the sgsn (gprs) is built. This patch adds conditions check if the tests mentioned abvove are needed or not. Change-Id: I6921e6198ea7f99fe5276f91cbc522091853bc4e --- M openbsc/tests/Makefile.am M openbsc/tests/testsuite.at 2 files changed, 8 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/openbsc refs/changes/63/963/1 diff --git a/openbsc/tests/Makefile.am b/openbsc/tests/Makefile.am index 0ebd2e2..468edd2 100644 --- a/openbsc/tests/Makefile.am +++ b/openbsc/tests/Makefile.am @@ -9,10 +9,6 @@ trau \ subscr \ mm_auth \ - xid \ - sndcp_xid \ - slhc \ - v42bis \ $(NULL) if BUILD_NAT @@ -40,6 +36,10 @@ SUBDIRS += \ sgsn \ oap \ + xid \ + sndcp_xid \ + slhc \ + v42bis \ $(NULL) endif endif diff --git a/openbsc/tests/testsuite.at b/openbsc/tests/testsuite.at index f18b734..4905cd1 100644 --- a/openbsc/tests/testsuite.at +++ b/openbsc/tests/testsuite.at @@ -126,24 +126,28 @@ AT_SETUP([xid]) AT_KEYWORDS([xid]) +AT_CHECK([test "$enable_sgsn_test" != no || exit 77]) cat $abs_srcdir/xid/xid_test.ok > expout AT_CHECK([$abs_top_builddir/tests/xid/xid_test], [], [expout], [ignore]) AT_CLEANUP AT_SETUP([sndcp_xid]) AT_KEYWORDS([sndcp_xid]) +AT_CHECK([test "$enable_sgsn_test" != no || exit 77]) cat $abs_srcdir/sndcp_xid/sndcp_xid_test.ok > expout AT_CHECK([$abs_top_builddir/tests/sndcp_xid/sndcp_xid_test], [], [expout], [ignore]) AT_CLEANUP AT_SETUP([slhc]) AT_KEYWORDS([slhc]) +AT_CHECK([test "$enable_sgsn_test" != no || exit 77]) cat $abs_srcdir/slhc/slhc_test.ok > expout AT_CHECK([$abs_top_builddir/tests/slhc/slhc_test], [], [expout], [ignore]) AT_CLEANUP AT_SETUP([v42bis]) AT_KEYWORDS([v42bis]) +AT_CHECK([test "$enable_sgsn_test" != no || exit 77]) cat $abs_srcdir/v42bis/v42bis_test.ok > expout AT_CHECK([$abs_top_builddir/tests/v42bis/v42bis_test], [], [expout], [ignore]) AT_CLEANUP -- To view, visit https://gerrit.osmocom.org/963 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I6921e6198ea7f99fe5276f91cbc522091853bc4e Gerrit-PatchSet: 1 Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Owner: dexter <pmaier at sysmocom.de>