This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Max gerrit-no-reply at lists.osmocom.org
Review at https://gerrit.osmocom.org/958
DTX: remove excessive logging
Decrease log verbosity - this will allow to avoid extra decoding of RTP
packet just for logging.
Change-Id: Ic797131b088fce80e553e0a7bb85ba744590b252
---
M src/osmo-bts-litecell15/tch.c
M src/osmo-bts-sysmo/tch.c
2 files changed, 4 insertions(+), 16 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/58/958/1
diff --git a/src/osmo-bts-litecell15/tch.c b/src/osmo-bts-litecell15/tch.c
index 57aafa6..b8c278d 100644
--- a/src/osmo-bts-litecell15/tch.c
+++ b/src/osmo-bts-litecell15/tch.c
@@ -302,10 +302,7 @@
const uint8_t *rtp_pl, unsigned int rtp_pl_len, uint32_t fn, bool marker)
{
uint8_t *payload_type;
- uint8_t *l1_payload, cmr;
- enum osmo_amr_type ft;
- enum osmo_amr_quality bfi;
- int8_t sti, cmi;
+ uint8_t *l1_payload;
int rc;
DEBUGP(DRTP, "%s RTP IN: %s\n", gsm_lchan_name(lchan),
@@ -335,10 +332,7 @@
if (marker) {
*payload_type = GsmL1_TchPlType_Amr_Onset;
rc = 0;
- osmo_amr_rtp_dec(rtp_pl, rtp_pl_len, &cmr, &cmi, &ft,
- &bfi, &sti);
- LOGP(DRTP, LOGL_ERROR, "Marker SPEECH frame AMR %s\n",
- get_value_string(osmo_amr_type_names, ft));
+ LOGP(DRTP, LOGL_DEBUG, "AMR SPEECH frame with Marker\n");
}
else {
*payload_type = GsmL1_TchPlType_Amr;
diff --git a/src/osmo-bts-sysmo/tch.c b/src/osmo-bts-sysmo/tch.c
index 5de8caa..0abb811 100644
--- a/src/osmo-bts-sysmo/tch.c
+++ b/src/osmo-bts-sysmo/tch.c
@@ -399,10 +399,7 @@
const uint8_t *rtp_pl, unsigned int rtp_pl_len, uint32_t fn, bool marker)
{
uint8_t *payload_type;
- uint8_t *l1_payload, cmr;
- enum osmo_amr_type ft;
- enum osmo_amr_quality bfi;
- int8_t sti, cmi;
+ uint8_t *l1_payload;
int rc;
DEBUGP(DRTP, "%s RTP IN: %s\n", gsm_lchan_name(lchan),
@@ -434,10 +431,7 @@
if (marker) {
*payload_type = GsmL1_TchPlType_Amr_Onset;
rc = 0;
- osmo_amr_rtp_dec(rtp_pl, rtp_pl_len, &cmr, &cmi, &ft,
- &bfi, &sti);
- LOGP(DRTP, LOGL_ERROR, "Marker SPEECH frame AMR %s\n",
- get_value_string(osmo_amr_type_names, ft));
+ LOGP(DRTP, LOGL_DEBUG, "AMR SPEECH frame with Marker\n");
}
else {
*payload_type = GsmL1_TchPlType_Amr;
--
To view, visit https://gerrit.osmocom.org/958
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic797131b088fce80e553e0a7bb85ba744590b252
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>