This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgPatch Set 6: Code-Review-1 (1 comment) sorry, one last request, and then we can finally merge it. thanks! https://gerrit.osmocom.org/#/c/803/6/openbsc/src/gprs/gprs_sndcp.c File openbsc/src/gprs/gprs_sndcp.c: Line 805: if (sgsn->cfg.pcomp_rfc1144.active || sgsn->cfg.pcomp_rfc1144.passive || you repeat those two lines in the if statement already five times in this single path. Please add an inline function so we can have an "if (any_pcomp_or_dcomp_active(sgsn))". -- To view, visit https://gerrit.osmocom.org/803 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6d36cbdf2f5c5f83ca9ba57c70452f02b8582e7e Gerrit-PatchSet: 6 Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-HasComments: Yes