This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
dexter gerrit-no-reply at lists.osmocom.orgReview at https://gerrit.osmocom.org/904 octphy: improved channel measurement Not entirely sure what problem this is fixing, depending on your comments here. Change-Id: Ib2de74e8ec6549f867ac0a04c554167b664ce9b6 --- M src/osmo-bts-octphy/l1_if.c 1 file changed, 5 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/04/904/1 diff --git a/src/osmo-bts-octphy/l1_if.c b/src/osmo-bts-octphy/l1_if.c index d2d765f..a567ba1 100644 --- a/src/osmo-bts-octphy/l1_if.c +++ b/src/osmo-bts-octphy/l1_if.c @@ -789,10 +789,10 @@ PRIM_OP_INDICATION, NULL); l1sap.u.info.type = PRIM_INFO_MEAS; l1sap.u.info.u.meas_ind.chan_nr = chan_nr; - l1sap.u.info.u.meas_ind.ta_offs_qbits = m->sBurstTiming; + l1sap.u.info.u.meas_ind.ta_offs_qbits = m->sBurstTiming4x; - l1sap.u.info.u.meas_ind.ber10k = (unsigned int)(m->usBERCnt * 100); - l1sap.u.info.u.meas_ind.inv_rssi = (uint8_t) (m->sRSSIDbm * -1); + l1sap.u.info.u.meas_ind.ber10k = m->usRxQualFullUp; + l1sap.u.info.u.meas_ind.inv_rssi = m->usRxLevelFullUp; /* l1sap wants to take msgb ownership. However, as there is no * msg, it will msgb_free(l1sap.oph.msg == NULL) */ @@ -992,7 +992,8 @@ memset(&l1sap, 0, sizeof(l1sap)); /* uplink measurement */ - process_meas_res(trx, chan_nr, &data_ind->MeasurementInfo); + if(sapi == cOCTVC1_GSM_SAPI_ENUM_SACCH) + process_meas_res(trx, chan_nr, &data_ind->MeasurementInfo); /* FIXME: check min_qual_norm! */ -- To view, visit https://gerrit.osmocom.org/904 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib2de74e8ec6549f867ac0a04c554167b664ce9b6 Gerrit-PatchSet: 1 Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Owner: dexter <pmaier at sysmocom.de>