[PATCH] osmo-bts[master]: rsl: improved log output

[dexter]

Review at  https://gerrit.osmocom.org/902

rsl: improved log output

improving the log output to show more details about the payload
type and the connection

Change-Id: Ifaa253e5baed5ca364dfbc046a7cb559f106bfbd
---
M src/common/rsl.c
1 file changed, 17 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/02/902/1

diff --git a/src/common/rsl.c b/src/common/rsl.c
index 493ff3b..84938d3 100644
--- a/src/common/rsl.c
+++ b/src/common/rsl.c
@@ -1429,13 +1429,13 @@
 	/* Connection ID */
 	msgb_tv16_put(msg, RSL_IE_IPAC_CONN_ID, htons(lchan->abis_ip.conn_id));
 
-	/* locally bound IP */
-	msgb_v_put(msg, RSL_IE_IPAC_LOCAL_IP);
-	msgb_put_u32(msg, lchan->abis_ip.bound_ip);
-
 	/* locally bound port */
 	msgb_tv16_put(msg, RSL_IE_IPAC_LOCAL_PORT,
 		      lchan->abis_ip.bound_port);
+
+	/* locally bound IP */
+	msgb_v_put(msg, RSL_IE_IPAC_LOCAL_IP);
+	msgb_put_u32(msg, lchan->abis_ip.bound_ip);
 
 	if (inc_pt2) {
 		/* RTP Payload Type 2 */
@@ -1584,21 +1584,27 @@
 		return tx_ipac_XXcx_nack(lchan, RSL_ERR_MAND_IE_ERROR,
 					 0, dch->c.msg_type);
 
-	/* any of these can be NULL!! */
-	speech_mode = TLVP_VAL(&tp, RSL_IE_IPAC_SPEECH_MODE);
-	payload_type = TLVP_VAL(&tp, RSL_IE_IPAC_RTP_PAYLOAD);
-	payload_type2 = TLVP_VAL(&tp, RSL_IE_IPAC_RTP_PAYLOAD2);
-
-	if (TLVP_PRESENT(&tp, RSL_IE_IPAC_REMOTE_IP))
+	if (TLVP_PRESENT(&tp, RSL_IE_IPAC_REMOTE_IP)) {
 		connect_ip = tlvp_val32_unal(&tp, RSL_IE_IPAC_REMOTE_IP);
+		LOGP(DRSL, LOGL_NOTICE, "connect_ip %d \n", connect_ip );
+	}
 	else
 		LOGP(DRSL, LOGL_NOTICE, "CRCX does not specify a remote IP\n");
 
-	if (TLVP_PRESENT(&tp, RSL_IE_IPAC_REMOTE_PORT))
+	if (TLVP_PRESENT(&tp, RSL_IE_IPAC_REMOTE_PORT)) {
 		connect_port = tlvp_val16_unal(&tp, RSL_IE_IPAC_REMOTE_PORT);
+		LOGP(DRSL, LOGL_NOTICE, "connect_port %d \n", connect_port );
+	}
 	else
 		LOGP(DRSL, LOGL_NOTICE, "CRCX does not specify a remote port\n");
 
+	/* any of these can be NULL!! */
+	speech_mode = TLVP_VAL(&tp, RSL_IE_IPAC_SPEECH_MODE);
+	LOGP(DRSL, LOGL_NOTICE, "speech_mode %d \n",*speech_mode );
+	payload_type = TLVP_VAL(&tp, RSL_IE_IPAC_RTP_PAYLOAD);
+	LOGP(DRSL, LOGL_NOTICE, "Pay load type %d \n",*payload_type );
+	payload_type2 = TLVP_VAL(&tp, RSL_IE_IPAC_RTP_PAYLOAD2);
+
 	if (dch->c.msg_type == RSL_MT_IPAC_CRCX && connect_ip && connect_port)
 		inc_ip_port = 1;
 

-- 
To view, visit https://gerrit.osmocom.org/902
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifaa253e5baed5ca364dfbc046a7cb559f106bfbd
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: dexter <pmaier at sysmocom.de>