[MERGED] openbsc[master]: properly #include <openbsc/gsm_data.h> from gsm_subscriber.h

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Mon Sep 19 11:50:43 UTC 2016


Neels Hofmeyr has submitted this change and it was merged.

Change subject: properly #include <openbsc/gsm_data.h> from gsm_subscriber.h
......................................................................


properly #include <openbsc/gsm_data.h> from gsm_subscriber.h

Don't use quoted, local include, use <> style include.

Cosmetic: also move stdbool.h include to the top to keep osmocom and openbsc
includes grouped.

Change-Id: Iaa3dc36768f96f6b8c91010a2ba389fdc37f1503
---
M openbsc/include/openbsc/gsm_subscriber.h
1 file changed, 3 insertions(+), 2 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/openbsc/include/openbsc/gsm_subscriber.h b/openbsc/include/openbsc/gsm_subscriber.h
index 3d7c244..314d619 100644
--- a/openbsc/include/openbsc/gsm_subscriber.h
+++ b/openbsc/include/openbsc/gsm_subscriber.h
@@ -1,11 +1,12 @@
 #ifndef _GSM_SUBSCR_H
 #define _GSM_SUBSCR_H
 
-#include "gsm_data.h"
+#include <stdbool.h>
+
 #include <osmocom/core/linuxlist.h>
 #include <osmocom/gsm/protocol/gsm_23_003.h>
 
-#include <stdbool.h>
+#include <openbsc/gsm_data.h>
 
 #define GSM_NAME_LENGTH 160
 

-- 
To view, visit https://gerrit.osmocom.org/850
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iaa3dc36768f96f6b8c91010a2ba389fdc37f1503
Gerrit-PatchSet: 2
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder



More information about the gerrit-log mailing list