[MERGED] openbsc[master]: cosmetic: various comment, whitespace tweaks

[Neels Hofmeyr]

Neels Hofmeyr has submitted this change and it was merged.

Change subject: cosmetic: various comment, whitespace tweaks
......................................................................


cosmetic: various comment, whitespace tweaks

Change-Id: I131939cfba4d67d7e2c935341deeb14d09523fee
---
M openbsc/include/openbsc/gsm_data.h
M openbsc/src/libbsc/bsc_api.c
M openbsc/src/libmsc/gsm_04_08.c
M openbsc/tests/bsc/bsc_test.c
4 files changed, 4 insertions(+), 5 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/openbsc/include/openbsc/gsm_data.h b/openbsc/include/openbsc/gsm_data.h
index 939e0ee..9317717 100644
--- a/openbsc/include/openbsc/gsm_data.h
+++ b/openbsc/include/openbsc/gsm_data.h
@@ -103,7 +103,7 @@
 	uint8_t last_seen_nr;
 };
 
-/* the per subscriber data for lchan */
+/* active radio connection of a mobile subscriber */
 struct gsm_subscriber_connection {
 	struct llist_head entry;
 
diff --git a/openbsc/src/libbsc/bsc_api.c b/openbsc/src/libbsc/bsc_api.c
index b8b5967..8c830a3 100644
--- a/openbsc/src/libbsc/bsc_api.c
+++ b/openbsc/src/libbsc/bsc_api.c
@@ -247,7 +247,6 @@
 	if (!conn)
 		return NULL;
 
-	/* Configure the time and start it so it will be closed */
 	conn->lchan = lchan;
 	conn->bts = lchan->ts->trx->bts;
 	lchan->conn = conn;
diff --git a/openbsc/src/libmsc/gsm_04_08.c b/openbsc/src/libmsc/gsm_04_08.c
index c30fbb0..76217ae 100644
--- a/openbsc/src/libmsc/gsm_04_08.c
+++ b/openbsc/src/libmsc/gsm_04_08.c
@@ -1088,7 +1088,7 @@
 
 	if (subscr) {
 		subscr_update(subscr, bts,
-				GSM_SUBSCRIBER_UPDATE_DETACHED);
+			      GSM_SUBSCRIBER_UPDATE_DETACHED);
 		DEBUGP(DMM, "Subscriber: %s\n", subscr_name(subscr));
 
 		subscr->equipment.classmark1 = idi->classmark1;
@@ -3657,7 +3657,7 @@
 	return 0;
 }
 
-/* here we get data from the BSC level... */
+/* Main entry point for GSM 04.08/44.008 Layer 3 data (e.g. from the BSC). */
 int gsm0408_dispatch(struct gsm_subscriber_connection *conn, struct msgb *msg)
 {
 	struct gsm48_hdr *gh = msgb_l3(msg);
diff --git a/openbsc/tests/bsc/bsc_test.c b/openbsc/tests/bsc/bsc_test.c
index d032f61..cc45652 100644
--- a/openbsc/tests/bsc/bsc_test.c
+++ b/openbsc/tests/bsc/bsc_test.c
@@ -139,7 +139,7 @@
 	conn->bts = bts;
 	conn->sccp_con = sccp_con;
 
-	/* start testinh with proper messages */
+	/* start testing with proper messages */
 	printf("Testing BTS<->MSC message scan.\n");
 	for (i = 0; i < ARRAY_SIZE(test_scan_defs); ++i) {
 		const struct test_definition *test_def = &test_scan_defs[i];

-- 
To view, visit https://gerrit.osmocom.org/854
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I131939cfba4d67d7e2c935341deeb14d09523fee
Gerrit-PatchSet: 3
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>