[PATCH] osmo-bts[master]: lc15, sysmo: Use SID_FIRST_P1 to initiate DTX

[Max]

Hello Harald Welte, Jenkins Builder,

I'd like you to reexamine a change.  Please visit

    https://gerrit.osmocom.org/692

to look at the new patch set (#2).

lc15, sysmo: Use SID_FIRST_P1 to initiate DTX

Some phone seems to not send SID_FIRST_P2 message which seems like a
different understanding of the DTX spec. L1 accommodates for that by
using P1 to supply data for SID. Hence we should use it to initiate DTX
and ignore P2 message in case of AMR HR.

Change-Id: Iaf993b89caa0ad49b97d1c745dcaf039f867f018
---
M src/osmo-bts-litecell15/tch.c
M src/osmo-bts-sysmo/tch.c
2 files changed, 2 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/92/692/2

diff --git a/src/osmo-bts-litecell15/tch.c b/src/osmo-bts-litecell15/tch.c
index cbe7edc..e06c4cf 100644
--- a/src/osmo-bts-litecell15/tch.c
+++ b/src/osmo-bts-litecell15/tch.c
@@ -462,8 +462,7 @@
 	case GsmL1_TchPlType_Amr:
 		rmsg = l1_to_rtppayload_amr(payload, payload_len, lchan);
 		break;
-	case GsmL1_TchPlType_Amr_SidFirstP2:
-		/* L1 do not give us SID_FIRST data, just indication */
+	case GsmL1_TchPlType_Amr_SidFirstP1:
 		memcpy(sid_first, payload, payload_len);
 		int len = osmo_amr_rtp_enc(sid_first, 0, AMR_SID, AMR_GOOD);
 		if (len < 0)
diff --git a/src/osmo-bts-sysmo/tch.c b/src/osmo-bts-sysmo/tch.c
index 2d86fca..b1ab086 100644
--- a/src/osmo-bts-sysmo/tch.c
+++ b/src/osmo-bts-sysmo/tch.c
@@ -565,8 +565,7 @@
 	case GsmL1_TchPlType_Amr:
 		rmsg = l1_to_rtppayload_amr(payload, payload_len, lchan);
 		break;
-	case GsmL1_TchPlType_Amr_SidFirstP2:
-		/* L1 do not give us SID_FIRST data, just indication */
+	case GsmL1_TchPlType_Amr_SidFirstP1:
 		memcpy(sid_first, payload, payload_len);
 		int len = osmo_amr_rtp_enc(sid_first, 0, AMR_SID, AMR_GOOD);
 		if (len < 0)

-- 
To view, visit https://gerrit.osmocom.org/692
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iaf993b89caa0ad49b97d1c745dcaf039f867f018
Gerrit-PatchSet: 2
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder