This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.org
Patch Set 3: Code-Review-1
(2 comments)
https://gerrit.osmocom.org/#/c/803/3/openbsc/src/gprs/gprs_sndcp_dcomp.c
File openbsc/src/gprs/gprs_sndcp_dcomp.c:
Line 174: if (skip) {
so if we have no compression configured, we still suffer the dynamic allocation of a new msgb and the memcpy. This is not good. If no compression is active, we should neither copy the msgb, nor have any memcpy. The same is true for both compression and decompression, and counts for header as well as payload compression. Please modify the patch accordingly.
Line 338: if (!comp_entity) {
I think
--
To view, visit https://gerrit.osmocom.org/803
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6d36cbdf2f5c5f83ca9ba57c70452f02b8582e7e
Gerrit-PatchSet: 3
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: Yes