This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgPatch Set 36: Code-Review-1 (2 comments) https://gerrit.osmocom.org/#/c/644/36/openbsc/src/gprs/v42bis.c File openbsc/src/gprs/v42bis.c: Line 735 I think it is better to keep the original code as unmodified as possible, i.e. simply have #defines for this to do nothing, and to have a span_log macro to expand to DEBUGP. This way it will be easy to forward-port any updates/fixes in upstram spandsp if ever needed. https://gerrit.osmocom.org/#/c/644/36/openbsc/tests/v42bis/Makefile.am File openbsc/tests/v42bis/Makefile.am: Line 19: -lgtp -lrt -lm I think we should have a LIBGTP_LIBS or similar, rather than -lgtp. -- To view, visit https://gerrit.osmocom.org/644 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I689413f2541b6def0625ce6bd96f1f488f05f99d Gerrit-PatchSet: 36 Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-HasComments: Yes