This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Holger Freyther gerrit-no-reply at lists.osmocom.orgPatch Set 6: (1 comment) Max pointed out why it needs to be a const reference and then I removed my objection. I have had not re-read the patch then. Looking at it now it seems good to go. https://gerrit.osmocom.org/#/c/552/6/src/encoding.cpp File src/encoding.cpp: Line 39: static inline bool write_tai(bitvec *dest, unsigned& wp, int8_t tai) > Let me repeat the question. Why should wp be a mutable reference here? Max pointed out that bitvec_write_field takes a const reference to advance the write index (wi not write pointer) -- To view, visit https://gerrit.osmocom.org/552 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I786bf7fc999d401cc3d9e7f1e7a1fba953b5d458 Gerrit-PatchSet: 6 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: Max <msuraev at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Holger Freyther <holger at freyther.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <msuraev at sysmocom.de> Gerrit-HasComments: Yes