This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgPatch Set 1: Code-Review-1 (3 comments) i'm sorry for my negative comments, but I'm not sure it is worth spending time on such patches... https://gerrit.osmocom.org/#/c/854/1/openbsc/include/openbsc/gsm_data.h File openbsc/include/openbsc/gsm_data.h: Line 106: /* mobile subscriber data */ you change from one no longer correct comment to another one that is misleading? The subscriber_conection represents only the persistent state we keep during an active radio connection of the subscriber. sure, it is subscriber data, but it is not to be confused with struct gsm_subscriber, right? https://gerrit.osmocom.org/#/c/854/1/openbsc/include/openbsc/gsm_data_shared.h File openbsc/include/openbsc/gsm_data_shared.h: Line 384: /* One TRX (transceiver) in a BTS */ seriously? I think if you start expanding all acronyms everywhere, you'd have a lot of time to do. Somebody who works on BTS or BSC source code and doesn't know what a TRX is, is probably looking at the wrong codebase anyway. https://gerrit.osmocom.org/#/c/854/1/openbsc/src/libmsc/gsm_04_08.c File openbsc/src/libmsc/gsm_04_08.c: Line 3660: /* Main entry point for receiving data from the BSC|RNC level. */ If you touch it anyway: Layer3 data? GSM 04.08/44.008 Layer 3 data? -- To view, visit https://gerrit.osmocom.org/854 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I131939cfba4d67d7e2c935341deeb14d09523fee Gerrit-PatchSet: 1 Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-HasComments: Yes