[PATCH] openbsc[master]: cosmetic: various comment, whitespace tweaks

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Fri Sep 16 01:23:19 UTC 2016


Review at  https://gerrit.osmocom.org/854

cosmetic: various comment, whitespace tweaks

Change-Id: I131939cfba4d67d7e2c935341deeb14d09523fee
---
M openbsc/include/openbsc/gsm_data.h
M openbsc/include/openbsc/gsm_data_shared.h
M openbsc/src/libmsc/gsm_04_08.c
M openbsc/tests/bsc/bsc_test.c
4 files changed, 5 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/openbsc refs/changes/54/854/1

diff --git a/openbsc/include/openbsc/gsm_data.h b/openbsc/include/openbsc/gsm_data.h
index daa5a4d..d50b187 100644
--- a/openbsc/include/openbsc/gsm_data.h
+++ b/openbsc/include/openbsc/gsm_data.h
@@ -103,7 +103,7 @@
 	uint8_t last_seen_nr;
 };
 
-/* the per subscriber data for lchan */
+/* mobile subscriber data */
 struct gsm_subscriber_connection {
 	struct llist_head entry;
 
diff --git a/openbsc/include/openbsc/gsm_data_shared.h b/openbsc/include/openbsc/gsm_data_shared.h
index ce2e9b7..4ae2585 100644
--- a/openbsc/include/openbsc/gsm_data_shared.h
+++ b/openbsc/include/openbsc/gsm_data_shared.h
@@ -381,7 +381,7 @@
 	struct gsm_lchan lchan[TS_MAX_LCHAN];
 };
 
-/* One TRX in a BTS */
+/* One TRX (transceiver) in a BTS */
 struct gsm_bts_trx {
 	/* list header in bts->trx_list */
 	struct llist_head list;
diff --git a/openbsc/src/libmsc/gsm_04_08.c b/openbsc/src/libmsc/gsm_04_08.c
index c30fbb0..680ce93 100644
--- a/openbsc/src/libmsc/gsm_04_08.c
+++ b/openbsc/src/libmsc/gsm_04_08.c
@@ -1088,7 +1088,7 @@
 
 	if (subscr) {
 		subscr_update(subscr, bts,
-				GSM_SUBSCRIBER_UPDATE_DETACHED);
+			      GSM_SUBSCRIBER_UPDATE_DETACHED);
 		DEBUGP(DMM, "Subscriber: %s\n", subscr_name(subscr));
 
 		subscr->equipment.classmark1 = idi->classmark1;
@@ -3657,7 +3657,7 @@
 	return 0;
 }
 
-/* here we get data from the BSC level... */
+/* Main entry point for receiving data from the BSC|RNC level. */
 int gsm0408_dispatch(struct gsm_subscriber_connection *conn, struct msgb *msg)
 {
 	struct gsm48_hdr *gh = msgb_l3(msg);
diff --git a/openbsc/tests/bsc/bsc_test.c b/openbsc/tests/bsc/bsc_test.c
index d032f61..cc45652 100644
--- a/openbsc/tests/bsc/bsc_test.c
+++ b/openbsc/tests/bsc/bsc_test.c
@@ -139,7 +139,7 @@
 	conn->bts = bts;
 	conn->sccp_con = sccp_con;
 
-	/* start testinh with proper messages */
+	/* start testing with proper messages */
 	printf("Testing BTS<->MSC message scan.\n");
 	for (i = 0; i < ARRAY_SIZE(test_scan_defs); ++i) {
 		const struct test_definition *test_def = &test_scan_defs[i];

-- 
To view, visit https://gerrit.osmocom.org/854
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I131939cfba4d67d7e2c935341deeb14d09523fee
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>



More information about the gerrit-log mailing list