This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgPatch Set 3: Code-Review+1 (21 comments) some comments if you'd like to be perfectionist about it ;) ...not that there aren't important tasks waiting :P https://gerrit.osmocom.org/#/c/838/3/openbsc/src/gprs/Makefile.am File openbsc/src/gprs/Makefile.am: Line 40: drop this blank line? https://gerrit.osmocom.org/#/c/838/3/openbsc/src/ipaccess/Makefile.am File openbsc/src/ipaccess/Makefile.am: Line 49: ipaccess_config_LDADD = $(top_builddir)/src/libbsc/libbsc.a \ start with '= \' and libbsc.a in next line? https://gerrit.osmocom.org/#/c/838/3/openbsc/src/libbsc/Makefile.am File openbsc/src/libbsc/Makefile.am: Line 20: libbsc_a_SOURCES = abis_nm.c \ abis_nm.c on next line? https://gerrit.osmocom.org/#/c/838/3/openbsc/src/libmgcp/Makefile.am File openbsc/src/libmgcp/Makefile.am: Line 39: drop this blank line? https://gerrit.osmocom.org/#/c/838/3/openbsc/src/libmsc/Makefile.am File openbsc/src/libmsc/Makefile.am: Line 25: libmsc_a_SOURCES = auth.c \ auth.c in next line? https://gerrit.osmocom.org/#/c/838/3/openbsc/src/osmo-bsc/Makefile.am File openbsc/src/osmo-bsc/Makefile.am: Line 27: drop one of the two blank lines https://gerrit.osmocom.org/#/c/838/3/openbsc/src/osmo-bsc_mgcp/Makefile.am File openbsc/src/osmo-bsc_mgcp/Makefile.am: Line 25: osmo_bsc_mgcp_LDADD = $(top_builddir)/src/libcommon/libcommon.a \ libcommon.a on next line? https://gerrit.osmocom.org/#/c/838/3/openbsc/src/osmo-bsc_nat/Makefile.am File openbsc/src/osmo-bsc_nat/Makefile.am: Line 28: double blank line, drop one https://gerrit.osmocom.org/#/c/838/3/openbsc/src/utils/Makefile.am File openbsc/src/utils/Makefile.am: Line 30: drop this blank line? https://gerrit.osmocom.org/#/c/838/3/openbsc/tests/Makefile.am File openbsc/tests/Makefile.am: Line 14: drop this blank line? Line 21: and this Line 27: and this Line 33: and this Line 38: and this Line 47: double blank line https://gerrit.osmocom.org/#/c/838/3/openbsc/tests/channel/Makefile.am File openbsc/tests/channel/Makefile.am: Line 24: $(NULL) I like it when things related to one binary don't have blank lines in-between, but it seems the other places all have a blank line now. https://gerrit.osmocom.org/#/c/838/3/openbsc/tests/db/Makefile.am File openbsc/tests/db/Makefile.am: Line 34: db_test_LDADD = \ tab before '\' should be space https://gerrit.osmocom.org/#/c/838/3/openbsc/tests/mgcp/Makefile.am File openbsc/tests/mgcp/Makefile.am: Line 30: drop this blank line? https://gerrit.osmocom.org/#/c/838/3/openbsc/tests/sgsn/Makefile.am File openbsc/tests/sgsn/Makefile.am: Line 13: drop this blank line? Line 70: drop this blank line? https://gerrit.osmocom.org/#/c/838/3/openbsc/tests/subscr/Makefile.am File openbsc/tests/subscr/Makefile.am: Line 32: subscr_test_LDADD = $(top_builddir)/src/libbsc/libbsc.a \ double space before '='. libbsc on next line? -- To view, visit https://gerrit.osmocom.org/838 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifa21513c007072314097b7bec188579972dc1694 Gerrit-PatchSet: 3 Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Owner: ahuemer <alexander.huemer at xx.vu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-HasComments: Yes