osmo-pcu[master]: EGPRS: add test case to show LI decoding bug

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Thu Sep 15 10:59:59 UTC 2016


Patch Set 11:

(2 comments)

https://gerrit.osmocom.org/#/c/825/10/tests/tbf/TbfTest.cpp
File tests/tbf/TbfTest.cpp:

Line 2701: 	test_tbf_li_decoding();
> now fixing it
that's nice, but no reason to post a comment.


https://gerrit.osmocom.org/#/c/825/11/tests/tbf/TbfTest.cpp
File tests/tbf/TbfTest.cpp:

Line 1917: 		Exist_Multislot_capability = 1;
presreq is great;
You should also have a shortcut for
MS_RA_capability_value[0].u.Content and/or ..Multislot_capability
(after which the pmsradiocap shortcut can probably be dropped again)


-- 
To view, visit https://gerrit.osmocom.org/825
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ida410dab1aa4b0cf3e15b2090586377eb19b2469
Gerrit-PatchSet: 11
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Owner: arvind.sirsikar <arvind.sirsikar at radisys.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: arvind.sirsikar <arvind.sirsikar at radisys.com>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list