This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgPatch Set 2: (2 comments) https://gerrit.osmocom.org/#/c/826/2/src/decoding.cpp File src/decoding.cpp: Line 77: chunks[num_chunks].is_complete = true; I know what the spec says, which I quoted in my question. Quoting the same spec again doesn't answer my question. To approve of the patch, I need to understand what it means in terms of this code. My understanding is lacking here: does is_complete refer to the PDU? If it does, then is_complete == true would mean that the PDU always ends, but the spec says the PDU may continue in the next data block. So I guess is_complete refers only to one part of a PDU. Since you probably have a better understanding of what is happening here, can you explain in detail why is_complete must always be true here? And once you've explained it and you're sure it is correct, you should combine the row 4 if {} with above row 2a if {}, as I posted above. https://gerrit.osmocom.org/#/c/826/1/tests/edge/EdgeTest.cpp File tests/edge/EdgeTest.cpp: Line 513: OSMO_ASSERT(chunks[1].offset == 1); > No. Due to current bug we see only 1 chunk. i.e index 0. with current fix w ah of course, now I see the num_chunks == 2 assertion above. -- To view, visit https://gerrit.osmocom.org/826 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2cd0fca3ed28a553ede3f4b8a7d3267284dd2c9b Gerrit-PatchSet: 2 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: arvind.sirsikar <arvind.sirsikar at radisys.com> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Holger Freyther <holger at freyther.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: arvind.sirsikar <arvind.sirsikar at radisys.com> Gerrit-HasComments: Yes