This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgPatch Set 1: Code-Review-1 (6 comments) https://gerrit.osmocom.org/#/c/826/1//COMMIT_MSG Commit Message: Line 7: EGPRS: Adds support of row 4 of Table 10.4.14a.1 of 44.060 "EPGRS: fix interpretation of length indicator in RLC data block" Line 10: Which has been fixed in this patch. It would be good to briefly describe in what way the handling was not proper before this patch, so that I don't need to look up the spec to understand. Nevertheless, of course keep the reference to the table, add the full document name and version. https://gerrit.osmocom.org/#/c/826/1/src/decoding.cpp File src/decoding.cpp: Line 77: chunks[num_chunks].is_complete = true; Are you sure is_complete shall always be true here? The spec says "The current RLC data block contains a Upper Layer PDU that either fills the current RLC data block precisely or continues in the next RLC data blcok[sic]" So IIUC the PDU might continue in the next data block and thus might not be complete yet? If this is correct, you should/could join this 'else if' with above 'if', they are identical and li->e would be don't-care. https://gerrit.osmocom.org/#/c/826/1/tests/edge/EdgeTest.cpp File tests/edge/EdgeTest.cpp: Line 501: rdbi.cv = 1; why this change from 0 to 1? I'd have expected the test to remain unchanged except for the final assertions. Line 513: OSMO_ASSERT(chunks[1].offset == 1); could these additional asserts already be in the previous patch (with differing values)? https://gerrit.osmocom.org/#/c/826/1/tests/tbf/TbfTest.cpp File tests/tbf/TbfTest.cpp: Line 731: /* row 4 of Table 10.4.14a.1 */ this should be in the previous patch with a proper reference to the full document name. -- To view, visit https://gerrit.osmocom.org/826 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2cd0fca3ed28a553ede3f4b8a7d3267284dd2c9b Gerrit-PatchSet: 1 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: arvind.sirsikar <arvind.sirsikar at radisys.com> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Holger Freyther <holger at freyther.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-HasComments: Yes