This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgPatch Set 1: (5 comments) https://gerrit.osmocom.org/#/c/825/1//COMMIT_MSG Commit Message: Line 11: in 44.060. The test's expectation is corrected along with the bug Preferably name it as ETSI TS or 3GPP explicitly with full version information. https://gerrit.osmocom.org/#/c/825/1/tests/edge/EdgeTest.cpp File tests/edge/EdgeTest.cpp: Line 500: * TODO: simulate row 4 of Table 10.4.14a.1 The reference to Table 10.4... is worthless without the full document name. Line 522: OSMO_ASSERT(chunks[0].is_complete); you say "TODO: it should be complete" yet you assert that it is complete? I'd have expected the bug to cause is_complete == 0 then? https://gerrit.osmocom.org/#/c/825/1/tests/tbf/TbfTest.cpp File tests/tbf/TbfTest.cpp: Line 663: MS_RA_capability_value[0].u.Content. You're using ulreq.u.Packet_Resource_Request N times, if you fetch it into a local pointer var first you could make these lines a lot shorter. Same for ulreq.u.Packet_Resource_Request.MS_Radio_Access_capability. MS_RA_capability_value[0].u below. This would improve readability dramatically. Line 2011: ul_tbf = tbf_li_decoding(&the_bts, ts_no, tlli, &fn, qta, if tbf_li_decoding() is used only by this test, IMHO it should be defined right above test_tbf_li_decoding(), not a thousand lines further above. -- To view, visit https://gerrit.osmocom.org/825 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida410dab1aa4b0cf3e15b2090586377eb19b2469 Gerrit-PatchSet: 1 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: arvind.sirsikar <arvind.sirsikar at radisys.com> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Holger Freyther <holger at freyther.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: arvind.sirsikar <arvind.sirsikar at radisys.com> Gerrit-HasComments: Yes