This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgPatch Set 4: Code-Review-1 (1 comment) fine except for the luring null pointer segfault https://gerrit.osmocom.org/#/c/798/4/src/tbf.cpp File src/tbf.cpp: Line 380: gprs_rlcmac_dl_tbf *dl_tbf = as_dl_tbf(this); If this happens to not be a dl_tbf instance, as_dl_tbf() will return NULL. You need to guard against that. side note: In puristic C++ thought, this is a bit ugly: adding child class functionality in the base class is Not Good (tm). But class gprs_rlcmac_tbf seems to have been designed this way... So I guess it's not your fault, and on the plus side this avoids the overhead of virtual functions. "Class inheritance is highly overrated" -- To view, visit https://gerrit.osmocom.org/798 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I41aa807068520460fd665a55e3529e60f6bbb630 Gerrit-PatchSet: 4 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: arvind.sirsikar <arvind.sirsikar at radisys.com> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Holger Freyther <holger at freyther.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: arvind.sirsikar <arvind.sirsikar at radisys.com> Gerrit-HasComments: Yes