osmo-pcu[master]: Refactoring: New function to calculate EGPRS DL window size

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

arvind.sirsikar gerrit-no-reply at lists.osmocom.org
Mon Sep 12 07:26:23 UTC 2016


Patch Set 2:

(2 comments)

https://gerrit.osmocom.org/#/c/832/1/src/tbf.cpp
File src/tbf.cpp:

Line 1253: 	LOGP(DRLCMAC, LOGL_INFO, "%s: Setting EGPRS window size to %d\n",
> (technically, you added an indent here)
Fixed in latest series.


Line 1255: 
> After figuring out window() and the 'direction' member,
The function is moved to gprs_rlcmac_dl_tbf class.


-- 
To view, visit https://gerrit.osmocom.org/832
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7c7777d43f843bbd3421503fc2a8600f148ca035
Gerrit-PatchSet: 2
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Owner: arvind.sirsikar <arvind.sirsikar at radisys.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: arvind.sirsikar <arvind.sirsikar at radisys.com>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list