This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgPatch Set 1: (6 comments) In general I like these things to be consistent, but I have some bikesheds. https://gerrit.osmocom.org/#/c/838/1/openbsc/Makefile.am File openbsc/Makefile.am: Line 1: AUTOMAKE_OPTIONS = foreign dist-bzip2 1.6 $(NULL) Please explain the $(NULL)? This is the first time I'm seeing this. Line 15: pkgconfigdir = $(libdir)/pkgconfig $(NULL) you added a second space after '=' here. Let's have single spaces (or tabs). https://gerrit.osmocom.org/#/c/838/1/openbsc/include/openbsc/Makefile.am File openbsc/include/openbsc/Makefile.am: Line 2: abis_nm.h \ I appreciate that the indenting is now the same on every line, but I was fine with the more compact block, with multiple entries on the same line. https://gerrit.osmocom.org/#/c/838/1/openbsc/src/Makefile.am File openbsc/src/Makefile.am: Line 2: $(all_includes) \ bikeshed ... we could agree to indent all of these with a single tab, regardless of how long the variable name is. That would drop a bunch of spaces-after-tabs. https://gerrit.osmocom.org/#/c/838/1/openbsc/src/gprs/Makefile.am File openbsc/src/gprs/Makefile.am: Line 21: I wouldn't add a blank line here as below is extending AM_CFLAGS. Line 63: I wouldn't separate osmo_gbproxy_* items with a blank line. (same with sgsn etc) -- To view, visit https://gerrit.osmocom.org/838 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifa21513c007072314097b7bec188579972dc1694 Gerrit-PatchSet: 1 Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Owner: ahuemer <alexander.huemer at xx.vu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-HasComments: Yes