This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgPatch Set 1: (2 comments) https://gerrit.osmocom.org/#/c/832/1/src/tbf.cpp File src/tbf.cpp: Line 1253: name(), ws); (technically, you added an indent here) Line 1255: window()->set_ws(ws); After figuring out window() and the 'direction' member, I'm not clear yet: does this function also apply to GPRS_RLCMAC_UL_TBF? It seems correct to use window() to decide for DL, since gprs_rlcmac_tbf is a parent class to gprs_rlcmac_dl_tbf. But are you sure it belongs in the parent class and applies to UL as well? After all, you're using dl_slots() above, which always returns 0 for UL. This makes me think you should rather add this function to gprs_rlcmac_dl_tbf? I see that the other patch modifies gprs_rlcmac_tbf::update(), which would have to do a slightly ugly cast then (or would need to become a virtual function and overloaded in dl). Do you have any insights that clarify this / that justify having this calculation for both DL and UL? -- To view, visit https://gerrit.osmocom.org/832 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7c7777d43f843bbd3421503fc2a8600f148ca035 Gerrit-PatchSet: 1 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: arvind.sirsikar <arvind.sirsikar at radisys.com> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Holger Freyther <holger at freyther.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-HasComments: Yes