This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgPatch Set 4: (1 comment) > In OsmoBTS there are already generated convolutional codes. > So, I spent some time finding corresponding polynomial sets for > some data types, which wasn't defined in the conv_gen.py generator. Sounds like excellent work! Did you find them mathematically, or in specs out there? :) > Despite the EDGE's MCS levels use the same generator polynomial > with different lengths, I wasn't able to find any details about > EDGE convolutional transcoding, so I merely copied those tables > from OsmoBTS into a separate file. Ah, so there's two parts here. The commit log sounded at first like there was one set of codes. Sounds like it makes sense to split in two commits to make things perfectly clear. > I still have some doubts, related to MCS codes... > They aren't covered by GSM 05.03, so should I migrate them > in separate commit? Should I use a separate file? Which name to > use for this file? Yes and yes -- feel free to invent a new file name. A GSM spec number would be best to match the other file names -- but you say the EDGE codes are not covered by a specific GSM spec? As a fallback I'd suggest something like 'gsm_edge_coding.c' or 'gsm_mcs_coding.c'? I assume you have a better understanding of what name would be proper. BTW, osmo-nitb's main C file is still called 'bsc_hack.c' :) (Though libosmocore would be a place where we're stricter about naming.) https://gerrit.osmocom.org/#/c/816/4/src/gsm/gsm0503_conv_edge.c File src/gsm/gsm0503_conv_edge.c: Line 62: > Yes, it is a code part from OsmoBTS, and there was even more blank lines, t I think it would be best to first copy the code from OsmoBTS exactly as-is, preferably so that a diff between the files (or code chunks) ends up completely empty. Then add any cosmetic changes in a subsequent commit. (Same for all other cosmetics we've commented on.) -- To view, visit https://gerrit.osmocom.org/816 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I257a5d015798ee9e690fd035ca97fd971cf9f60a Gerrit-PatchSet: 4 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com> Gerrit-HasComments: Yes