osmo-bts[master]: LC15: fix coding style

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Tue Sep 6 17:18:51 UTC 2016


Patch Set 1: Code-Review-1

(1 comment)

> This variable is unused. Please ignore it.

If this 'i' is unused, then you should not add it in this commit.

https://gerrit.osmocom.org/#/c/807/1/src/osmo-bts-litecell15/calib_file.c
File src/osmo-bts-litecell15/calib_file.c:

Line 151:         st->fp = fopen(fname, "rb");
when you're fixing indenting, might as well fix the whole function block at the same time...


-- 
To view, visit https://gerrit.osmocom.org/807
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I18d07822df1f36a6855b72f83e2d73d221aa8735
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Minh-Quang Nguyen <minh-quang.nguyen at nutaq.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Minh-Quang Nguyen <minh-quang.nguyen at nutaq.com>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list