This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgPatch Set 2: (3 comments) waiting for Holger to remove the -2... Some minor details remain. https://gerrit.osmocom.org/#/c/798/2/src/tbf.cpp File src/tbf.cpp: Line 380: Even nicer would be to do the cosmetic change of moving the calculation to a separate function in a separate commit, and adding this functional change in a second, small commit. I won't block on this though. Line 1244: unsigned int num_pdch = pcu_bitcount(this->dl_slots()); can 'this->' be omitted? Line 1256: "base(%d) num_pdch(%d) ws_pdch(%d)\n", you should not have multiple lines in a LOGP. Also, you should keep commits small: here, you move code and modify it at the same time. For patch readability, it is preferred to have only code modifications in the code-move that are absolutely necessary for the build (no cosmetic nor functional fixes). Do your tweaks and fixups in a separate commit. Since this is small, it's not a big problem here, but please try to stick to this principle. -- To view, visit https://gerrit.osmocom.org/798 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I41aa807068520460fd665a55e3529e60f6bbb630 Gerrit-PatchSet: 2 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: arvind.sirsikar <arvind.sirsikar at radisys.com> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Holger Freyther <holger at freyther.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: arvind.sirsikar <arvind.sirsikar at radisys.com> Gerrit-HasComments: Yes