This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Minh-Quang Nguyen gerrit-no-reply at lists.osmocom.orgPatch Set 1: >include/osmo-bts/oml.h >Line 50: >who defined those cause value? are they from TS 12.21? If yes, the >definitions should definitely go into libosmgsm abis_nm.h. If >the'yre custom definitions, we need to mention it clearly here, and >if possible also introduce a OSMO in the definition to make it >explicit those cause values are not standard cause values. Like >NM_EVT_CAUSE_OMSO_... Those custom alarms cause values are defined by NuranWireless. They will be named with OSMO to indicate non-standard cause values in next patches set. >src/common/bts.c >Line 180: >is the 'ceased alarm' mechanism really Litecell 1.5 specific, or is >it a more general feature that is shared among all BTS models? >src/common/rsl.c It is a general feature that is shared among other BTS models. >Line 397: >we typically don't indent the 'case' below a 'switch' >src/osmo-bts-litecell15/calib_file.c To be updated in next patches set >Line 156: >space missing, also in several other places. To be updated in next patches set -- To view, visit https://gerrit.osmocom.org/809 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic4e088a3af115d3d5a124b61c1e92eed277d3469 Gerrit-PatchSet: 1 Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Owner: Minh-Quang Nguyen <minh-quang.nguyen at nutaq.com> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Minh-Quang Nguyen <minh-quang.nguyen at nutaq.com> Gerrit-HasComments: No