This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgPatch Set 1: (3 comments) https://gerrit.osmocom.org/#/c/812/1/include/osmocom/gsm/protocol/gsm_08_58.h File include/osmocom/gsm/protocol/gsm_08_58.h: Line 304: IPAC_WEIGHTED_AVE, We usually use "avg" as abbreviation for average. Preferably use *_AVG instead of *_AVE. Line 312: IPAC_MS_BTS_DIS_AVE *_AVG Line 658: ave_method:3; As seen in the other example, we usually would write 'uint8_t' before every name. Personally, I like it the way your patch is now, because it is easy to see where the 8-bit / byte bounds are. But let's check with other reviewers whether we should stick with the other style. -- To view, visit https://gerrit.osmocom.org/812 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie1853697f4cff5ff98654fa1cae6c68e28a0076b Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: Minh-Quang Nguyen <minh-quang.nguyen at nutaq.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-HasComments: Yes