osmo-pcu[master]: EGPRS: EPDAN decoding: add test case to show no ack_nack len...

[Neels Hofmeyr]

Patch Set 6:

> These are random values so I have kept this way.

Arvind, this comment of yours is not accurate.
How did you get the idea that these bits are random?

I have taken a closer look now and both my suggestion to memset URBB
as well as your argumentation are nonsense.

Without the fix in csn1.c, 8 bits are read even though only 6 bits remain
in the bit vector, leading to a read past the vector's end. But this is
caught and bitvec_get_bit_pos() returns -EINVAL, which is *not* random.

So your test should always expect

        OSMO_ASSERT(!strcmp(osmo_hexdump(urbb->URBB, 13),
                            "7f ff ff ee 00 00 00 00 00 00 00 00 ea "));

This will never end up a different byte sequence with the
given input.

(The only variation would be that EINVAL were defined a different
value than we expect, != 22. In that case we would compose
the expected bytes using the actual current -EINVAL value.)

-- 
To view, visit https://gerrit.osmocom.org/765
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8da84794748f2e81722c3eca69b46ccc3a21552e
Gerrit-PatchSet: 6
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Owner: arvind.sirsikar <arvind.sirsikar at radisys.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: arvind.sirsikar <arvind.sirsikar at radisys.com>
Gerrit-HasComments: No